Remove dependency on `PropsParserContext`#42616

Closed

cipolleschi wants to merge 1 commit into

cipolleschi:export-D52999204

cipolleschi commented Jan 23, 2024

Contributor

Summary:
PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the surfaceId and the contextContainer. We don't need to bring to graphics the whole dependencies of core due to these two parts.

This change break the dependency by passing along only the elements that we actually need.

Changelog

[Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext

Differential Revision: D52999204

facebook-github-bot added the CLA Signed label

facebook-github-bot commented Jan 23, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52999204

facebook-github-bot added p: Facebook Partner fb-exported labels

analysis-bot commented Jan 23, 2024 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,066,829	-10
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,450,426	-19
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 3869ae4
Branch: main

cipolleschi force-pushed the export-D52999204 branch from 7b4b51c to 3e941ad Compare

January 25, 2024 10:00

facebook-github-bot commented Jan 25, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52999204

cipolleschi force-pushed the export-D52999204 branch from 3e941ad to 8deab5c Compare

January 26, 2024 10:01

facebook-github-bot commented Jan 26, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52999204

cipolleschi force-pushed the export-D52999204 branch from 8deab5c to b726213 Compare

January 26, 2024 10:53

facebook-github-bot commented Jan 26, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52999204

cipolleschi force-pushed the export-D52999204 branch from b726213 to 14044a1 Compare

January 26, 2024 10:55

facebook-github-bot commented Jan 26, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52999204

cipolleschi force-pushed the export-D52999204 branch from 14044a1 to 8dfe5d5 Compare

January 29, 2024 13:55

facebook-github-bot commented Jan 29, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52999204

cipolleschi force-pushed the export-D52999204 branch from 8dfe5d5 to 2f5683a Compare

January 29, 2024 13:56

facebook-github-bot commented Jan 29, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52999204

cipolleschi force-pushed the export-D52999204 branch from 2f5683a to 0b91bf0 Compare

January 29, 2024 14:01

facebook-github-bot commented Jan 29, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52999204

cipolleschi force-pushed the export-D52999204 branch from 0b91bf0 to 4bd44fe Compare

January 29, 2024 14:16

facebook-github-bot commented Jan 29, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52999204

facebook-github-bot commented Jan 29, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52999204

cipolleschi force-pushed the export-D52999204 branch from 4bd44fe to 260dc3f Compare

January 29, 2024 14:32

facebook-github-bot commented Jan 29, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52999204


          Remove dependency on PropsParserContext (react#42616)

bc40417

Summary:

PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the `surfaceId` and the `contextContainer`. We don't need to bring to graphics the whole dependencies of core due to these two parts.

This change break the dependency by passing along only the elements that we actually need.

## Changelog
[Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext

Reviewed By: sammy-SC

Differential Revision: D52999204

cipolleschi force-pushed the export-D52999204 branch from 260dc3f to bc40417 Compare

January 29, 2024 14:33

facebook-github-bot commented Jan 29, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52999204

facebook-github-bot closed this in

5bf5f4b

facebook-github-bot added the Merged label

facebook-github-bot commented Jan 29, 2024

Contributor

This pull request has been merged in 5bf5f4b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner